catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Use a hierarchical layout for the Related Events table in analysis view. #1019

Open catapult-bot opened 9 years ago

catapult-bot commented 9 years ago

Issue by philippebeaudoin Thursday Jun 11, 2015 at 15:29 GMT Originally opened as https://github.com/google/trace-viewer/issues/1019


Right now the Related Events table can become quite cluttered (see screenshot). It would be useful to turn the table into a hierarchy with "Flow", "Connected Events" and "Slice Hierarchy" as subcategories.

image

catapult-bot commented 9 years ago

Comment by dj2 Thursday Jun 11, 2015 at 17:10 GMT


One other question I had. The group on the right takes up a lot of screen space. Can we instead move that into it's own tab instead of sharing space with the regular analysis view? (The analysis panes can become wide, having to scroll horizontally is a bit of a pain)

catapult-bot commented 9 years ago

Comment by philippebeaudoin Thursday Jun 11, 2015 at 20:20 GMT


I think that right table could be made much thinner by default, which would work well with its current placement.

One thing I agree with, though, is that it feels a bit weird to associate it with the "slices" tab. It feels like these are events related to you whole selection, not just to the "slices" in your selection. As such it should be a top-level component. (ie, side-by-side with the tabbed panel allowing you to view slices, flow events, etc.)

Pinging @natduca for opinions.

catapult-bot commented 9 years ago

Comment by natduca Monday Jun 15, 2015 at 02:11 GMT


Wondering if a basic bug is the left part of the multi-event-selection view.

If you have

[          a                ]  [      b        ]
      [     b     ] [  c  ]

Right now, when sel=[a,b,b] we show 2 b's and one a. When you have this, though, the totals become bonkers because the "b" time is included in a, for instance.

Is the right thing to pause thinking about relateds for a bit, and make the left hand side work hierarchically? E.g. take all the slices and find only the ones that are toplevel, then turn those into a tree view that shows

  a
    b(1)
  b(2)

Thinking out loud. Open question whether the subrows off of a should be [b1, c] or just [b1]. Open to suggestions.