search

catppuccin / cursors

🐁 Soothing pastel cursors for GTK/Plasma/Hyprland
GNU General Public License v2.0
462 stars 16 forks source link

feat: support `hyprcursor` #23

Closed trowgundam closed 6 months ago

trowgundam commented 6 months ago

I've added support for hyprcursor.

This is a re-implementation of #18 based on the recent reworking of the repository. It was easier to just re-implement things than trying to rebase and fixing things due to the change from make to just.

sgoudham commented 6 months ago

Hi @trowgundam,

I've set up a CI/CD workflow which builds all the themes and outputs them as artifacts. I've refactored some of the script and the build command to be more explicit, now using just all and just all_with_hyprcursor for verbosity. Accents is now a default parameter so you can do just build mocha and just build mocha blue etc

Could you please confirm the assets inside of the artifacts linked below work as intended on your system? https://github.com/catppuccin/cursors/actions/runs/9325025650/artifacts/1557799918

trowgundam commented 6 months ago

Hi @sgoudham,

It looks good and works for me. There were some weird spaces before the version line in the manifest, but your one commit fixed that when I built it myself. The only other weird thing is the version is surrounded by quotes and has some sort of, what I'm guessing is, a comment, but it didn't stop Hyprland from loading the theme. So it's probably not a big deal. I don't think most of that metadata is actually used for anything outside of the name anyways.

sgoudham commented 6 months ago

The only other weird thing is the version is surrounded by quotes and has some sort of, what I'm guessing is, a comment, but it didn't stop Hyprland from loading the theme.

Yeah I took a gamble on that one, instead of using the git version, I think it'd make sense to use the release please version that the theme will be released under (the comment allows for release-please to automatically update the version on PRs) but maybe it's better to keep the git sha? I'm not too fussed about that one.

trowgundam commented 6 months ago

Hyprland could use the theme just fine. I had originally tried to figure out a good way to grab a version when I first wrote the script, so it's actually perfect like that. As long as the theme works, it's good in my book.

sgoudham commented 6 months ago

Great! I'm happy to approve once you add yourself to the AUTHORS file! :D

trowgundam commented 6 months ago

Done