search

catppuccin / grub

🌕 Soothing pastel theme for Grub2 & Ventoy
MIT License
351 stars 13 forks source link

Selected and Unselected Item Padding Differs #1

Closed ghost closed 2 years ago

ghost commented 2 years ago

As the title says. I don't know if it's a normal behavior, but just a little bit annoying personally.

elkrien commented 2 years ago

As the title says. I don't know if it's a normal behavior, but just a little bit annoying personally.

I think i fixed it. Please test.

ghost commented 2 years ago

As the title says. I don't know if it's a normal behavior, but just a little bit annoying personally.

I think i fixed it. Please test.

Yes it's fixed, thanks. But lastly, as a background you use flat colored image. Instead of image, can't you just replace it with one color?

elkrien commented 2 years ago

As the title says. I don't know if it's a normal behavior, but just a little bit annoying personally.

I think i fixed it. Please test.

Yes it's fixed, thanks. But lastly, as a background you use flat colored image. Instead of image, can't you just replace it with one color?

Thx - I did like You suggested. I updated theme and also added You to Thanks To section in README.md. Let me know if You are ok with this.

ghost commented 2 years ago

Looks perfect, thank you!

ghost commented 2 years ago

I found a problem after your changes. In the menu, if you select another menu (advanced options, for example) and go back and start the operating system, GRUB will throw an error. Unfortunately I can't send screenshots right now.

elkrien commented 2 years ago

I found a problem after your changes. In the menu, if you select another menu (advanced options, for example) and go back and start the operating system, GRUB will throw an error. Unfortunately I can't send screenshots right now.

I was able to reproduce this error - it happens when desktop-color is used. When background.png is used everything works ok on my machine. I have returned to previous version with image as background.

ghost commented 2 years ago

Okay then. Shall I close the issue?