search

catppuccin / obsidian

💎 Soothing pastel theme for Obsidian
MIT License
340 stars 15 forks source link

Add more italic font weights. #47

Closed hiimsergey closed 10 months ago

hiimsergey commented 10 months ago

There is one more small problem connected to #46. Since italic fonts can also be bold or part of a heading, I would suggest adding the respective weight of the font too.

Before 20230808_17h43m24s_grim

After 20230808_17h48m01s_grim

I just imported the counterparts to the normal fonts (400 to 800). I'm not sure if all are necessary, only 400, 600 and 700 showed change after removing again.

This is my first ever pull request. I apologize if I did something wrong.

mbeckrich commented 10 months ago

Nice job with your first PR! I went ahead and cut+pasted your imports to the _font.scss file, then ran sass to update theme.css. I also used the inspector in Obsidian (cmd+alt+i) to check that each weight works (it does). If you want to check on your end, use some sample text, bring up the inspector, and insert in the element.style { } box:

font-weight: 400;
font-weight: 500;
font-weight: 600;
font-weight: 700;
font-weight: 800;

Uncheck them all, then reenable them one-by-one. You should be able to see the weights changing each time. Sorry if you already know how to do this, but I read your post as you doing it manually and I didn't want you to have to keep doing that!