search

catppuccin / palette

🎨 Soothing pastel theme to use within your projects!
https://www.npmjs.com/package/@catppuccin/palette
MIT License
459 stars 36 forks source link

Seperate projects out to submodules to facilitate better access control #25

Closed nyxkrage closed 2 years ago

nyxkrage commented 2 years ago

Currently if someone needs to maintain for example the Rust crate, they have to be given access to the entire repo This is obviously not an ideal situation. A solution to this would be to move each project out into a separate repo and then including them in this repo as a submodules, that way this repo just acts as a sort of hub.

This should probably just be done for future projects being added and perhaps the Rust crate as its still fairly new, as backporting this to the other projects in here, is a pain that probably isn't worth it.

sgoudham commented 2 years ago

I'd be really interested in hearing @catppuccin/core's opinions on this, especially because it's one of the main repositories.

I personally agree and it makes sense to do this going forward and not trying to retroactively applying it to everything

nekowinston commented 2 years ago

Agreed, this is why I wish GitHub had projects like GitLab.

We can, however, control access with CODEOWNERS like Monorepos do.

nyxkrage commented 2 years ago

Code Owners doesn't restrict permissions but only notifies the owners when someone tries to change the code AFAIK, so I don't think it makes sense in this case

unseen-ninja commented 2 years ago

Basically the same question we also try to answer for the Userstyles, right? Personally I think submodules would make a lot of sense, as it's likely the easiest way to achieve proper separation. Codeowners are an alternative worth exploring tho.

sgoudham commented 2 years ago

Going forward (rust, python, etc). We decided to separate out these modules into their own repositories (catppuccin/python and catppuccin/rust, etc)