cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
586 stars 331 forks source link

feat: use Amazon Linux 2023 for runner manager instance #1138

Closed scamp closed 4 months ago

scamp commented 5 months ago

Description

Adds support for Amazon Linux 2023 and removes the dmesg logs from Cloudwatch as it wasn't useful at all.

Closes #1137

github-actions[bot] commented 5 months ago

Hey @scamp! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

kayman-mk commented 4 months ago

Looks good to me, but I'd like to test it with the "old" AMI.

kayman-mk commented 4 months ago

Works with the old AMI as well.

scamp commented 4 months ago

Thanks for review and testing! I believe its ready for merging now.