cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
586 stars 331 forks source link

fix: remove leading `/` from SSM parameter names in policy ARNs #1146

Closed Kqirk closed 4 months ago

Kqirk commented 4 months ago

Description

Using SSM parameter hierarchies (as described in https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-paramstore-hierarchies.html) results in an error. See #1128

Several workarounds exist, but using trimprefix makes them superfluous. Having a / as first character results in the above mentioned error.

Verification

Checked the ARN of parameter /test/test. It showed up as arn:aws:ssm:eu-central-1:123456789012:parameter/test/test in the console. So no // at first place.

github-actions[bot] commented 4 months ago

Hey @Kqirk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.