cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
586 stars 331 forks source link

GitLab Runner 15.8.2 can't be installed on Amazon Linux 2023 #1147

Closed nexonen closed 4 months ago

nexonen commented 4 months ago

Describe the bug

Module version: 7.8.0

After the update to use Amazon Linux 2023, the runner version 15.8.2 isn't available to be installed as it isn't found in the package repository. Version 15.8.2 is the default version specified in variables.tf.

A list of gitlab-runner packages released for Amazon Linux 2023 is here.

To Reproduce

Steps to reproduce the behavior:

  1. Provision a new runner using module version 7.8.0 with gitlab-runner version 15.8.2
  2. Observe that the runner doesn't connect to the gitlab instance after registration
  3. Connect to the instance and look at the logs in /var/log/messages, see Error: Unable to find a match: gitlab-runner-15.8.2
  4. Observe that gitlab-runner package is not installed

Expected behavior

An available version of gitlab-runner should be specified as the default for the runner_gitlab.runner_version variable.

kayman-mk commented 4 months ago

Gosh, I wasn't aware of this. Absolutely true. I prefer to not use the default as the Runner should match to your GitLab version. Maybe we should make this a mandatory parameter?