cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
586 stars 331 forks source link

ci: disable Terraform tests #1152

Closed kayman-mk closed 4 months ago

kayman-mk commented 4 months ago

Description

These tests were experimental and causes trouble as the infrastructure is not cleaned up in a consistent way. After a few times the step fails with

│ Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: 98d896d9-f9e1-41c4-abb3-169776c8d348, api error VpcLimitExceeded: The maximum number of VPCs has been reached.
│ 
│   with module.vpc.aws_vpc.this[0],
│   on .terraform/modules/test.tests.variables.setup_tests.vpc/main.tf line 28, in resource "aws_vpc" "this":
│   28: resource "aws_vpc" "this" {
│ 

As the test quality and coverage is bad, I decided to disable them.

github-actions[bot] commented 4 months ago

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

github-actions[bot] commented 4 months ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.05s
✅ COPYPASTE jscpd yes no 1.61s
⚠️ MARKDOWN markdownlint 1 0 1 0.32s
✅ MARKDOWN markdown-link-check 1 0 0.58s
✅ REPOSITORY checkov yes no 14.03s
✅ REPOSITORY dustilock yes no 0.2s
✅ REPOSITORY gitleaks yes no 1.34s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.78s
✅ REPOSITORY secretlint yes no 1.02s
✅ REPOSITORY syft yes no 0.33s
✅ REPOSITORY trivy-sbom yes no 0.83s
✅ REPOSITORY trufflehog yes no 4.33s
✅ SPELL cspell 3 0 2.24s
✅ YAML prettier 1 0 0 0.46s
✅ YAML v8r 1 0 4.81s
✅ YAML yamllint 1 0 0.29s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_