cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
586 stars 331 forks source link

feat: make the graceful terminate Lambda timeout configurable #1164

Closed kayman-mk closed 3 months ago

kayman-mk commented 3 months ago

Description

Add var.runner_terminate_ec2_timeout_duration with a default of 90 seconds. Makes it possible to configure the timeout in case hundreds of workers are controlled by a single GitLab Runner Agent. Otherwise the Lambda function might fail and does not remove any worker in case the Agent is stopped.

Closes #1149

github-actions[bot] commented 3 months ago

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

github-actions[bot] commented 3 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.62s
✅ REPOSITORY checkov yes no 15.61s
✅ REPOSITORY dustilock yes no 0.38s
✅ REPOSITORY gitleaks yes no 1.22s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.6s
✅ REPOSITORY secretlint yes no 0.97s
✅ REPOSITORY syft yes no 0.34s
✅ REPOSITORY trivy-sbom yes no 1.43s
✅ REPOSITORY trufflehog yes no 4.5s
✅ SPELL cspell 6 0 2.94s
✅ TERRAFORM terraform-fmt 5 0 0 0.48s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_