search

causefx / Organizr

HTPC/Homelab Services Organizer - Written in PHP
GNU General Public License v3.0
5.12k stars 290 forks source link

SSO Fallback for Komga #1838

Closed MVethana closed 2 years ago

MVethana commented 2 years ago
Organizr Version: V 2.1.1890
Branch: v2-master
WebServer: Caddy
Operating System: Windows 10
Problem Description:

Komga SSO not compatible with Plex Backend only

Reproduction Steps:

Komga SSO when authentication is set to Plex Backend only fails with php-requests/1.7 Password Bad credentials due to no password existing, enable plex backend only and SSO to komga fails

Errors on screen? If so paste here:

Screenshots and conversation available from discord here https://discord.com/channels/374648602632388610/374662006701293569/976985278977835048

HalianElf commented 2 years ago

Are you using oAuth to login or the login form? It should work fine with login form with Plex Backend only.

MVethana commented 2 years ago

oauth no password and komga sso requires a password which is what is causing the issue

HalianElf commented 2 years ago

Right, you need to use the login form. oAuth isn't compatible with any SSO that doesn't use Plex tokens. So you either need to disable the oAuth login method and only use the login form or deal with not using SSO for Komga. This isn't a bug and is not fixable.

MVethana commented 2 years ago

When talking with @causefx on discord he mentioned he had thought of a workaround before utilizing a master password but just needed to figure out how he wanted to implement it. Since he mentioned it is something he wants to make compatible in the future the issue should be left open to track progress on the implementation

HalianElf commented 2 years ago

Ok I'll reopen it then. Sounds like what he's talking about is basically SSO fallback like we have for Ombi/Petio/Overseerr so not really true SSO.

Edited the title to reflect that but this should really go to Feature Requests.

MVethana commented 2 years ago

Komga SSO already has a fallback account.

What we discussed was using the oauth as the username and a master password so that any komga users aren't all put into the same fallback account as a fix to the fact that oauth isn't compatible in komgas current implementation.

As an alternative Komga does support OAuth which could also be used

https://komga.org/installation/oauth2.html#advanced-configuration

causefx commented 2 years ago

added in dev