search

cavallium / CoordinatesObfuscator

Hide the real coordinates to the players
GNU Affero General Public License v3.0
35 stars 11 forks source link

Support for Nova #22

Open Vlad0Crystal opened 1 year ago

Vlad0Crystal commented 1 year ago

Is it possible to support this plugin? There are no conflicts, but there is a small nuisance, because players do not see custom blocks. I tested the issue with your plugin. Is it possible to fix this? https://www.spigotmc.org/resources/nova-modding-framework-1-19-3.93648/

Vlad0Crystal commented 1 year ago

image

cavallium commented 1 year ago

Do you see some errors in the server/client logs?

ByteZ1337 commented 1 year ago

This issue is caused by us sending pre-serialized data for performance reasons, which leads to the packet not being picked up by Coordinates Obfuscator and thus spawning the display entity at the wrong coordinates. Not sure how fixable this is with only ProtocolLib, but the best approach would probably be to intercept any FriendlyByteBufs with the specific Packet IDs and change the fixed length coordinates in said ByteBuf. I think ItemsAdder also sends FriendByteBufs so I'm guessing that's incompatible right now as well.

cavallium commented 1 year ago

I never thought about third-party plugins sending pre-serialized packets when I developed this plugin, I should definitely handle that packets. Unfortunately, I am currently very busy with work and other personal projects, I don't have enough time to properly implement features like this for now.

Vlad0Crystal commented 1 year ago

Are there any options, for example, to add support for a fee? I could pay for

cavallium commented 1 year ago

Unfortunately I have a full-time job and I don't have time to dedicate to it, even if you pay me. Maybe there are some other developers here that are ok with that.