typo for triangles-adjacency

azimut commented 5 years ago

think it should be :triangles-adjacency instead of :triangle-adjacency

https://github.com/cbaggers/varjo/blob/c345a93d1374f58874fc972e796d1f121443bb10/src/varjo.internals/internal-types.lisp#L394

If not errors with:

:TRIANGLE-ADJACENCY is not defined as a keyword for enum type #<CFFI::FOREIGN-ENUM CL-OPENGL-BINDINGS:ENUM>.
   [Condition of type SIMPLE-ERROR]

Restarts:
 0: [CONTINUE] Livesupport: Continue
 1: [RETRY] Retry SLIME REPL evaluation request.
 2: [*PROCESS-INPUT] Continue reading input.
 3: [ABORT] Return to SLIME's top level.
 4: [CLOSE-CONNECTION] Close SLIME connection.
 5: [ABORT] Exit debugger, returning to top level.

Backtrace:
  0: (CFFI::%FOREIGN-ENUM-VALUE #<CFFI::FOREIGN-ENUM CL-OPENGL-BINDINGS:ENUM> :TRIANGLE-ADJACENCY :ERRORP T)
  1: (CL-OPENGL-BINDINGS:DRAW-ELEMENTS-INSTANCED-BASE-VERTEX :TRIANGLE-ADJACENCY 720 5123 0 50 0)
  2: (SHADOW-ROMAN-COLUMN-PIPE #<CEPL-CONTEXT #<THREAD "main thread" RUNNING {10005205B3}>> #<CEPL:BUFFER-STREAM (55) :LENGTH 720 :INDEXED T> NIL :POSITIONS #<UBO (5) ROMAN-COLUMNS> :LIGHTS #<SSBO (4) LIGH..
  3: ((:METHOD DRAW-COLUMN-SILLOUTE (ROMAN-COLUMN T)) #<ROMAN-COLUMN {10066BAB53}> #<PERS {10075B5203}>) [fast-method]
  4: ((:METHOD DRAW! NIL)) [fast-method]
  5: (PLAY :START NIL)
  6: (SB-INT:SIMPLE-EVAL-IN-LEXENV (PLAY :START) #<NULL-LEXENV>)
  7: (EVAL (PLAY :START))
 --more--

cbaggers commented 5 years ago

Looks correct to me. I'll fix that now

cbaggers commented 5 years ago

:) https://github.com/cbaggers/varjo/commit/acb5049925391f8852904557ceb9f0a106eaaa82

cbaggers / varjo

typo for triangles-adjacency #223