search

cbcoding / RadioEnhancer

Adds many new features to Pandora's new HTML5 interface.
http://cbcoding.com
7 stars 11 forks source link

Blocking top ribbon causes the top of the page to get cut off #13

Closed CrossfireCurt closed 12 years ago

CrossfireCurt commented 12 years ago

This is a terrible bug report and I don't really know how to reproduce it. Aaron Meurer sent us a note and screenshot, but if the setting to block the top ribbon is enabled, every once in a while it cuts off the top of the player controls.

zephster commented 12 years ago

It may have something to do with the ribbon not even being displayed before it's hidden. We detect it's existence by .pandoraRibbonContainer and .ribbonContent on the DOMNodeInserted event, so we technically see it before it's even presented to the user via the slide-down animation. I think by sending the click dispatch to the close button before it's even shown is causing other elements to move up by the height of the ribbon - 40px, for whatever reason. I think we should just remove it from the DOM instead of 'clicking' close.

zephster commented 12 years ago

I think that worked, haven't had the issue yet. I used to get it frequently myself, it was pretty annoying.

zephster commented 12 years ago

Yeah, definitely fixed.