search

cbcoding / RadioEnhancer

Adds many new features to Pandora's new HTML5 interface.
http://cbcoding.com
7 stars 11 forks source link

Added option to change title based on current song #32

Closed DanH42 closed 10 years ago

DanH42 commented 11 years ago

This change adds an option (defaulted to enabled) to change the window's title text to the current playing song.

It uses the format "[Title] by [Artist] - Pandora", which is backwards from the usually more common "Artist - Title", but I felt like the song's title was more important to see, and Chrome tabs aren't usually long enough to show both without hovering.

CrossfireCurt commented 11 years ago

Dan, this looks good. The only thing I'd change is the text for the option checkbox. Maybe make it "put song info in window title"? What do you think?

DanH42 commented 11 years ago

Sounds good. Do you want to make that change, or should I update the pull request?

DanH42 commented 10 years ago

Any updates on why this is still open? Is there something else that should be added/changed?

CrossfireCurt commented 10 years ago

Hey Dan - sorry, yeah I think it's all set as long as you're good with it. I think its already in the latest release too, right? I'll have to close it tomorrow or Tuesday since I don't have much access right now.

On Monday, April 28, 2014, Dan Hlavenka notifications@github.com wrote:

Any updates on why this is still open? Is there something else that should be added/changed?

— Reply to this email directly or view it on GitHubhttps://github.com/cbcoding/RadioEnhancer/pull/32#issuecomment-41521855 .

DanH42 commented 10 years ago

It should be all good to go, although it's not in the current release. The current version in the Web Store is 1.4.3, and I didn't touch the version number in this commit.