fixing 'use of uninitialized memory' bug

cbg-ethz / shorah

Repo for the software suite ShoRAH (Short Reads Assembly into Haplotypes)

GNU General Public License v3.0

39 stars 14 forks source link

Closed DrYak closed 6 years ago

DrYak commented 6 years ago

values of members of 'tmp' struct are now re-initialised to sane defaults between runs

DrYak commented 6 years ago

Credits: thanks to @sposadac for documenting the problem well enough to enable that easy fix.

DrYak commented 6 years ago

And checks have passed. Yippee!

ozagordi commented 6 years ago

Seems great, thanks! It seems to me that this also fixes #9, am I right?

DrYak commented 6 years ago

Actually, yeah, you're right, it's the exact same problem as the one reported by Suzie. (this issues should be merged, somehow...)

DrYak commented 6 years ago

(Note: as this fix a bug, remember to bump up the version number so I can make a new bioconda package, too)

ozagordi commented 6 years ago

v1.1.3 ready now.

DrYak commented 6 years ago

Great! Could you also upload the shorah ".tar.bz2" boot-strapped tarball to the release page ?

ozagordi commented 6 years ago

Done, would you please check that you can install?

DrYak commented 6 years ago

Everything seems correct for now.

Now I'm moving toward merge-requesting the newer bioconda recipe upstream. If their tests succeeds, will have an updated bioconda package.

DrYak commented 6 years ago

Bioconda recipes pull request is awaiting its merge, with all CircleCI tests successfully passed.