search

cbrgm / githubevents

GitHub webhook events toolset for Go :rocket:
https://pkg.go.dev/github.com/cbrgm/githubevents#section-readme
Apache License 2.0
72 stars 4 forks source link

feature: missing type `repository_ruleset` #94

Open rbtcollins opened 2 months ago

rbtcollins commented 2 months ago

repository_rule is defined.

I'm not sure if you're using code generation or artisanal definitions, but would be willing to make a patch, unless new types are super easy for you :)

cbrgm commented 2 months ago

Heyho,

added the necessary parameters here. Sadly the event type is not available in the main google/go-github repository and has to be added there first. You can raise and issue there if you want, could be a cool first contribution, otherwise I'll do it probably in the next days.

Cheers!

rbtcollins commented 2 months ago

Great, thanks! I've filed an issue which obviously doesn't do the work, but does let folk know.

I doubt I'll get the CLA approved by legal in order to submit a patch to go-github in the short term :/. If only it was DCO or simple FLOSS.

cbrgm commented 1 month ago

Nice, it was merged last week. I'm waiting for the v67 release and will add the new webhook type then. Thanks for raising the issue!