cbusillo / BD_to_AVP

3D Blu-ray to Apple Vision Pro converter
GNU General Public License v3.0
99 stars 5 forks source link

File Not Found #11

Closed hectorluisjr closed 5 months ago

hectorluisjr commented 5 months ago

I did the quick install this morning so latest code.

I can see an mkv file being made in Finder.

At some point, the file disappears and the process crashes with:

No files found in /Users/hector/Desktop/[Movie name] with extensions: ['.mkv'] Traceback (most recent call last): File "/opt/homebrew/bin/bd-to-avp", line 8, in <module> sys.exit(main()) ^^^^^^ File "/Users/hector/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 786, in main process_each(input_args) File "/Users/hector/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 818, in process_each mkv_output_path = create_mkv_file(input_args, output_folder, disc_info) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/hector/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 1037, in create_mkv_file raise ValueError("No MKV file created.") ValueError: No MKV file created.

cbusillo commented 5 months ago

So far this has always been due to the Blu-ray containing no 3D tracks. Can you confirm it is a 3D Blu-ray?

hectorluisjr commented 5 months ago

I don't have a way to confirm 100% other than the iso is title 3D and the movie begins with references to 3D elements so I would assume that it is the case

cbusillo commented 5 months ago

Can you paste the full output including the command you used? Also can you screen shot what tracks MakeMKV shows?

hectorluisjr commented 5 months ago

hector@Hectors-MacBook-Pro Desktop % bd-to-avp --source TronLegacy.iso --output-commands --keep-files  

Processing TronLegacy.iso

Running command:

/Applications/MakeMKV.app/Contents/MacOS/makemkvcon --robot info TronLegacy.iso

Running Get disc and MVC video properties |

Removed existing directory: /Users/hector/Desktop/Tron Legacy

Custom MakeMKV profile created at /Users/hector/Desktop/Tron Legacy/custom_profile.mmcp.xml

Running command:

/Applications/MakeMKV.app/Contents/MacOS/makemkvcon --profile=/Users/hector/Desktop/Tron Legacy/custom_profile.mmcp.xml mkv iso:TronLegacy.iso 4 /Users/hector/Desktop/Tron Legacy

Running Rip disc to MKV file. |

No files found in /Users/hector/Desktop/Tron Legacy with extensions: ['.mkv']

Traceback (most recent call last):

File "/opt/homebrew/bin/bd-to-avp", line 8, in <module>

sys.exit(main())

^^^^^^

File "/Users/hector/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 786, in main

process_each(input_args)

File "/Users/hector/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 818, in process_each

mkv_output_path = create_mkv_file(input_args, output_folder, disc_info)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/Users/hector/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 1037, in create_mkv_file

raise ValueError("No MKV file created.")

ValueError: No MKV file created.

During script run: Screenshot 2024-05-31 at 6 42 03 PM

After script run:

Screenshot 2024-05-31 at 6 46 26 PM

cbusillo commented 5 months ago

Can you send a screen shot of the MakeMKV Title list? We are specifically looking for the StereoHigh track. That is what makes it a 3D BD.

Screenshot 2024-05-31 at 9 11 14 PM
hectorluisjr commented 5 months ago

Screenshot 2024-05-31 at 8 44 37 PM

May be related but when I open this source in MakeMKV, I get a warning about AnyDvd which I believe has to do with the Any! folder in the iso: https://www.reddit.com/r/makemkv/comments/f6z4wu/comment/fi9l5vq/

cbusillo commented 5 months ago

Try using the --keep-files flag to see if the outputted mkv is a working file and contains the 3d video track.

cbusillo commented 5 months ago

If you would like to send me the ISO, I can test it out for you. info@shinycomputers.com

cbusillo commented 5 months ago

Any luck with a different disc or the --keep-files?

hectorluisjr commented 5 months ago

--keep-files doesn't keep the .mkv file that is made but did leave behind a file: Tron Legacy_audio_PCM.mov. How would you suggest sending at 48GB iso?

cbusillo commented 5 months ago

Thats odd, --keep-files should keep all of the files. If you have enough space on a google drive or drop box, that usually works. Or maybe a mega upload.

Do you have a different iso to run just to see if it's an iso issue?

hectorluisjr commented 5 months ago

I don't have another iso but I sent you a link to this one

cbusillo commented 5 months ago

Downloading now, will test in a bit.

cbusillo commented 5 months ago

That is a bad rip with a bunch of errors. The left/right don't sync and most of the tracks don't export. I think someone probably remuxed it and broke the MVC. Try to find another ISO, untouched are best. People tend to break things when they mess with them. I'll leave this open so you can try a different iso or disc to confirm it's just a source file issue.

cbusillo commented 5 months ago

Did you have a chance to test with an untouched disc?

cbusillo commented 5 months ago

@hectorluisjr does this happen with ai upscale enabled? I think I found the issue. Some videos give a false error about the left/right resolutions being different. Looking at it now, but you may be able to bypass the error by turning off ai upscale for now.

Please update me when you have time so I can figure it out. Thank you!

hectorluisjr commented 5 months ago

I don't think I turned on that unless it's on by default. But I'm unable to test as I assumed it was the file and deleted it. Does it work for you? I also don't have another disc to test

cbusillo commented 5 months ago

@hectorluisjr sorry, I don't have that disc anymore. I added better errors on the GUI so it's more likely to tell you the issue. Please open a new issue if you have another problem. Hopefully the new version works for you!

hectorluisjr commented 5 months ago

Just a follow up, got another file and did it. Worked great. This might be related to my being on macOS 15 Beta but I did hit a snag where I had to run brew link fribidi to get the build to get past the one of the earlier steps. Thanks for making this!

cbusillo commented 5 months ago

@hectorluisjr thank you for the follow it. Let's assume the brew thing is related to the beta. Brew itself says that there will be issues. Glad to hear you are having good encodes.