cbusillo / BD_to_AVP

3D Blu-ray to Apple Vision Pro converter
GNU General Public License v3.0
99 stars 5 forks source link

Hangs when ripping a folder of files (Subtitle Issue) #36

Closed mikemonello closed 4 months ago

mikemonello commented 4 months ago

I haven't been able to complete an entire folder rather than file by file. Each time the program just "hangs" without an error or appearing to stop, but it isn't processing anything.

Here's what it looks like. The only way to know that it has frozen is that the animated icon stops moving.

Screenshot 2024-07-01 at 12 28 14 PM

In this case, it successfully converted the first file and hung on the second. I'm now ripping that second file by itself, with the exact same settings, I will report when complete.

Has anyone else been able to rip an entire folder of files successfully?

cbusillo commented 4 months ago

Does this always occur during the subs phase? converting a folder did work at one point, but perhaps changes to the subtitle handling introduced a bug.

cbusillo commented 4 months ago

I just ran this on four copies of my tester iso and it worked fine so there must be another issue involved.

mikemonello commented 4 months ago

Here's something: I have been running rips by File and when I run a rip, then pick a new file and run a new rip, it will hang. But if I quit and re-start the app, it will rip the same file just fine.

cbusillo commented 4 months ago

Are you saying you need to restart after every rip or just sometimes?

edeuss commented 4 months ago

@cbusillo It's also hanging for me trying to do mkv's, getting suck on the subtitle step.

Ready.Player.One.2018.{edition-3D MVC} - 3D MVC.mkv

Running Get disc and MVC video properties 
Finished Get disc and MVC video properties in 2 seconds

Using temporary folder: /Users/deuss/Movies/3D Output/ReadyPlayerOne2018edition-3D MVC - 3D MVC/tmp

Detecting crop parameters...

Running ffmpeg to extract video, audio, and subtitles from MKV 
Finished ffmpeg to extract video, audio, and subtitles from MKV in a minute

Running Sup subtitles extraction and SRT conversion 🌘

Let it sit for over an hour and no changes.

mikemonello commented 4 months ago

It doesn't always hang for me, but when it does, it's always at the subtitle phase. I used to let it sit for a long time, but I noticed that when it hangs the little black/yellow icon stops animating entirely.

mikemonello commented 4 months ago

If I don't restart after a successful rip, the chances are higher that it will fail on the second file. I have had this happen, quit, retry it with the exact same settings, and It works.

I'm wondering if the folder issue is a space issue, even though my drives have tons of space is it possible the app doesn't release the space properly and then hangs because there isn't enough?

mikemonello commented 4 months ago

I've been trying a bunch of conversions, and I'm getting a lot of hangs at

Running Sup subtitles extraction and SRT conversion 🌕

I've been running MakeMKV rips from downloaded ISO files that might have been remuxed as well as MKV files I ripped from ISO that I made myself from the BD, so it's not entirely an issue with remuxed BDs

I'm doing each as an individual file, not as part of a folder, FYI.

Netruk44 commented 4 months ago

I'm seeing this issue, too. If I convert one mkv everything works fine. If I use the same window to then convert another mkv, it hangs.

Unfortunately, I didn't mark down at which step it stopped at last. I just exited and restarted the app and it's working fine now. Next time it happens I'll see where it hangs.

mikemonello commented 4 months ago

I just had 5 MKV files in a row fail, quitting and restarting the app (0.2.133) each time. I'm going to try the ISO files just to see what it does.

Netruk44 commented 4 months ago

I used to let it sit for a long time, but I noticed that when it hangs the little black/yellow icon stops animating entirely.

Yes, I think this is probably important. I've noticed the icon stops animating as well.

mikemonello commented 4 months ago

I/m seeing that it handles subs differently for ISO files vs MKV. I tried to convert an MKV I ripped from an ISO and I noticed it rips the subtitles and puts them in the same folder as the INPUT file, not in the folder for the disk in the OUTPUT folder.

When converting the ISO file that I used to make the MKV file, it made the SRT files in 3 mins, but it kept all relevant temp files and the SRT file in the OUTPUT folder, not the INPUT folder like it did with the MKV file.

cbusillo commented 4 months ago

I/m seeing that it handles subs differently for ISO files vs MKV. I tried to convert an MKV I ripped from an ISO and I noticed it rips the subtitles and puts them in the same folder as the INPUT file, not in the folder for the disk in the OUTPUT folder.

When converting the ISO file that I used to make the MKV file, it made the SRT files in 3 mins, but it kept all relevant temp files and the SRT file in the OUTPUT folder, not the INPUT folder like it did with the MKV file.

This is due to pgsrip not having an output folder and working off the mkv, which won't be in the temporary file if you are ripping from MKV instead of ISO.

mikemonello commented 4 months ago

Would forcing the Input and output folder to be the same if starting with an MKV fix that?

cbusillo commented 4 months ago

I don’t believe the files being in that location is an issue. They are moved to the correct location. I think something else is causing an issue.

mikemonello commented 4 months ago

I was able to successfully convert directly from the same ISO that I ripped for the MKV file that didn't work.

edeuss commented 4 months ago

For some reason this one movie is getting stuck and the srt files are extracted with the source file instead of in the output folder.

Source file with SRTs:

Screenshot 2024-07-04 at 5 06 44 PM

Export folder:

Screenshot 2024-07-04 at 5 07 04 PM

I have tried two other blu rays I own and it doesn't happen. Just this one for some reason.

cbusillo commented 4 months ago

I tried something in v0.2.134 that may fix it if the issue you are talking about above is from different handling of iso/mkv. mkv are first copied to the output folder, then it proceeds like its working off an iso. Let me know if you see any improvement. It is building now.

cbusillo commented 4 months ago

Added another prerelease last night. I found some bugs specific to your issues.

mikemonello commented 4 months ago

I set a folder with 5 iso files to convert using 0.2.136 and all of them worked, subtitles included. No hangs!

cbusillo commented 4 months ago

I did a folder of mts, iso, and mkv and it worked correctly. I also mixed in one with bad subs (that was causing an issue when continuing) and much success. Are we ready to close this one?