search

cbusillo / BD_to_AVP

3D Blu-ray to Apple Vision Pro converter
GNU General Public License v3.0
99 stars 5 forks source link

Black bars #5

Closed ddevler closed 7 months ago

ddevler commented 7 months ago

This is more of an enhancement than a bug. Add the ability to crop the black bars from the top and bottom on certain videos.

ffmpeg crop detect and crop

cbusillo commented 7 months ago

Code is pushed up. I am testing now then I will update the package.

cbusillo commented 7 months ago

@ddevler go ahead and try it when you get a chance. I used 300 frames from ten minutes in and took the most occurring value. I think that pretty much eliminates false values, other than if the aspect ratio changes. Let me know if it works for you.

ddevler commented 7 months ago

ty. I'll give it a try see how it works out. It was just one those odd things. The black bars looked out of place unless had dark background. Specially after watching some movies from atv+ without them.

also not sure if makes a difference on load times or not, but noticed you didn't include the "-movflags +faststart" flags from tutorial you referenced. I meant to test that out see if can notice a difference..

cbusillo commented 7 months ago

I believe those flags would be irrelevant since the container and encoding are changed afterwards. Please let me know if they do make a difference. Auto crop was a great idea.

ddevler commented 7 months ago

From a quick check it looks good. I didn't notice any missing content on the edges when playing both versions at same time. There are some tools that do a frame comparison, but I didn't go that far.

I manually added faststart to output file to test. I didn't notice any difference. mp4box -inter 0 in.mp4 -out out.mp4

cbusillo commented 7 months ago

Sounds good, I will close this one, let me know if you need anything else or have any suggestions.