cc-archive / vocabulary-legacy

A cohesive design system & Vue component library to unify the web-facing Creative Commons
https://cc-vocabulary.netlify.app
MIT License
88 stars 129 forks source link

[Bug] Broken Link for CC Logomark in Footer Component #1099

Closed justaskulkarni closed 1 year ago

justaskulkarni commented 1 year ago

Description

I was playing around with vocabulary, trying to design some sample pages for CC-Resource-Archive. While using the Footer component from https://cc-vocabulary.netlify.app/?path=/docs/patterns-footer--default-story, I came across the issue. The link for CC Logomark is broken.

Reproduction

  1. Copy the footer code from https://cc-vocabulary.netlify.app/?path=/docs/patterns-footer--default-story into a text editor of your choice.
  2. Open it in a browser.
  3. The CC Logomark is not visible in the footer.
  4. The console shows the following error message: Failed to load resource: the server responded with a status of 404 (Not Found)

Expectation

The broken link needs to be fixed.

Screenshots

This is what the footer component looks like in my personal project: image Error in the console: image

Resolution

justaskulkarni commented 1 year ago

Current Code for the link: image

The Correct Code should be: image

I made this very change in my personal project and got the desired result as demonstrated in the screenshot below: image