search

cc-tweaked / cc-restitched

Other
80 stars 31 forks source link

Update for 1.18.2 Including the Computer Physics Logic Fix #129

Open Frankiscophil opened 1 year ago

Frankiscophil commented 1 year ago

Hello there! I'm here to suggest an update of this mod for 1.18.2 that includes the fix for Computer physics logic and how they interact with Redstone. Been having a difficult time with redstone-related builds that include CC and this bug report I found sums up the exact issue I'm having.

https://github.com/cc-tweaked/cc-restitched/issues/118

I know this is already fixed for 1.19 and above. However, there are plenty of modpacks in 1.18.2 with this mod included, specifically AOF5 for me, and I'm hoping for players like me and others to be able to play with CC in the state it should be with this version of Minecraft.

Have a good day and I hope to hear from this wonderful team regarding this request.

sayore commented 1 year ago

Pls fix

Merith-TK commented 1 year ago

Unfortunately waiting on more updates to be backported from CC:T and the 1.19 branch,

but if you need to, in the readme click the "gitpod" banner, This will have you login with github, but will open an premade workspace where you can compile the latest source code, and download it (the action has expired so... this is your one way for now)

https://github.com/cc-tweaked/cc-restitched/commit/75a95b79429f2f01a1a606311a80d590990ca781

Frankiscophil commented 1 year ago

I will admit, I don't know how to do that on Gitpod. So I tried it on Git Bash instead and the result was this.

https://pastebin.com/QWGjMxXP

I don't know if what I did was even the exact way to compile it but it was an attempt. I'd appreciate it very much if maybe someone can help me out with this.

cplir-c commented 1 year ago

That's gradle complaining that your Java version is too new Looking at this table, I think you were running Java 19. Java 17 or 18 might work instead?

Merith-TK commented 1 year ago

The issue for gitpod is easy!

Basically just press the gitpod button in the readme and do the same command you did in gitbash!

Gitpod is an full Linux environment with all of the tools required to build the mod from source and make changes as nessecary (Java extensions complain but once setup it works)

On Fri, Dec 9, 2022, 1:04 PM cplir-c @.***> wrote:

That's gradle complaining that your Java version is too new

— Reply to this email directly, view it on GitHub https://github.com/cc-tweaked/cc-restitched/issues/129#issuecomment-1344781044, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXRLCA5PEHBIAOHDAL3WMONFDANCNFSM6AAAAAARLZUCOM . You are receiving this because you commented.Message ID: @.***>

Merith-TK commented 1 year ago

I also JUST saw this reply to the gitpod thing, new job has me not have a lot of free time to work on things like that

On Fri, Dec 9, 2022, 1:14 PM Merith TK @.***> wrote:

The issue for gitpod is easy!

Basically just press the gitpod button in the readme and do the same command you did in gitbash!

Gitpod is an full Linux environment with all of the tools required to build the mod from source and make changes as nessecary (Java extensions complain but once setup it works)

On Fri, Dec 9, 2022, 1:04 PM cplir-c @.***> wrote:

That's gradle complaining that your Java version is too new

— Reply to this email directly, view it on GitHub https://github.com/cc-tweaked/cc-restitched/issues/129#issuecomment-1344781044, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXRLCA5PEHBIAOHDAL3WMONFDANCNFSM6AAAAAARLZUCOM . You are receiving this because you commented.Message ID: @.***>