search

cca-io / rescript-mui

ReScript bindings for MUI
MIT License
254 stars 52 forks source link

How to work with a11y props? #211

Closed TomiS closed 4 months ago

TomiS commented 4 months ago

Hey,

It appears accessibility props such as ariaLabel do not exist. Or maybe I've missed something?

I'm not deeply familiar with MUI implementation and whether these are defaulted somehow, but I'd assume it's at least a real problem with components like IconButton that have no text labels otherwise.

fhammerschmidt commented 4 months ago

Hey! You just reminded me that it is still not possible to override props when spreading into a record. Because otherwise I would just spread JsxDOM.domProps into CommonProps.t and call it a day.

I will at least copy over all aria props though since those always have the same type it seems.

fhammerschmidt commented 4 months ago

Made a new release that comes with ariaProps.

TomiS commented 4 months ago

Very nice! Thanks for the quick response!