search

cccraig / MugShot

Plugin for piwigo.
MIT License
15 stars 15 forks source link

Better tag management UI #9

Closed tekstrand closed 3 years ago

tekstrand commented 5 years ago

What

  1. Fixes tab URL in admin
  2. New UI for tag management
  3. Add the tag's url to defined_mugshots
    • This is done via a secondary sql query. Alternatively we could add a new column into the mugshot table for this to be stored in. I wasn't sure how to write a DB migration for that so that existing users of the plugin wouldn't have issues.

Test

  1. Test the follow for both the admin and standard user experiences where applicable
  2. Load a photo with no tags, add a tag then save
  3. Load a photo with no tags, add multiple tags then save
  4. Load a photo with tags
  5. As admin, delete tags and save

Screenshots

mugshot1

Screen Shot 2019-09-07 at 2 59 18 PM
m3eu commented 4 years ago

After upgrade to php 7.3 the following warning is displayed in the admin page: Warning: Use of undefined constant MUGSHOT_BASE_URL - assumed 'MUGSHOT_BASE_URL' (this will throw an Error in a future version of PHP)

this constant is used in @tekstrand changes, MUGSHOT_BASE_URL is used instead of PSHARE_ADMIN_BASE_URL.

SOLUTION => ? => replace MUGSHOT_BASE_URL with MUGSHOT_ADMIN