search

ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
991 stars 136 forks source link

"Image Expansion" crashed on node Post No.75127753 (co). (+1 other errors) #460

Open ccd0 opened 9 years ago

ccd0 commented 9 years ago

[Please describe the steps needed to reproduce this error.]

Script: 4chan X ccd0 v1.11.9.4 crx User agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.155 Safari/537.36 URL: https://boards.4chan.org/co/thread/75126233

TypeError: Cannot read property 'parentNode' of null at Clone.ImageExpand.node (chrome-extension://ohnjgmpcibpbafdlkimncjhflgedgpam/script.js:10426:27) at Callbacks.execute (chrome-extension://ohnjgmpcibpbafdlkimncjhflgedgpam/script.js:1052:17) at Object.Main.callbackNodes (chrome-extension://ohnjgmpcibpbafdlkimncjhflgedgpam/script.js:17377:12) at Fetcher.insert (chrome-extension://ohnjgmpcibpbafdlkimncjhflgedgpam/script.js:2161:12) at new Fetcher (chrome-extension://ohnjgmpcibpbafdlkimncjhflgedgpam/script.js:2140:14) at HTMLAnchorElement.QuotePreview.mouseover (chrome-extension://ohnjgmpcibpbafdlkimncjhflgedgpam/script.js:6285:7)

https://gitreports.com/cdn-cgi/pe/bag2?r[]=https%3A%2F%2Fjs-agent.newrelic.com%2Fnr-686.min.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT https://gitreports.com/cdn-cgi/pe/bag2?r[]=https%3A%2F%2Fwww.google-analytics.com%2Fanalytics.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT https://js-agent.newrelic.com/nr-686.min.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT https://www.google-analytics.com/analytics.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

ccd0 commented 9 years ago

I haven't been able to reproduce this. You should check whether this might be caused by a conflict with another extension by disabling all other extensions temporarily.

ccd0 commented 8 years ago

Seems to have recurred, still not sure what the cause is.

734

812

ccd0 commented 8 years ago

Note: The object that is null is this.file.thumb, where this is the Post object.

This is happening in a clone, so thumb is set here: https://github.com/ccd0/4chan-x/blob/1.11.32.4/src/classes/Post.Clone.coffee#L43 @file.thumb = $ '.fileThumb > [data-md5]', file

A possible cause would be some other extension removing the data-md5 attribute from the thumbnail before it was cloned, or removing the thumbnail.