search

ccfolier / niwatori-dice

The dice engine used in ccfolia
MIT License
13 stars 1 forks source link

I want additional PR for "CC" command #3

Open Chiether opened 5 years ago

Chiether commented 5 years ago

Sorry, I carelessly forgot texts.push('Fumble!!') at https://github.com/ccfolia/niwatori-dice/blob/master/src/plugins/coc.js#L11-L16

By the way. "always success (01)" is not defined as critical(success). But say to critical(success) in general.

@ccfolia san, which do you like

  1. keep it now.
  2. add texts.push('Fumble!!') only.
  3. add texts.push('Critical!') and texts.push('Fumble!!').

I follow your views.

ccfolier commented 5 years ago

@Chiether -san Thank you for the Issue.

It is a compatible command with BCDice so I think it is better to conform to BCDice. In BCDice it is expression "決定的成功", but I think that it is ok if we can understand it is special success.

If we dislike the expression "Critical", we can use texts.push('Always success') and texts.push('Fumble') etc.

Chiether commented 5 years ago

@ccfolia san Right. I think "決定的" means "critical" and "conclusively (always)". I guess so texts.push('Always success') is better because critical-success has damage-effect in combat.

I will check BCDice and rulebook again and make PR in a few days.

thx.