Optimize payload exclusion logic in security rule creation. - Githubissues

cdot65 / pan-scm-sdk

Python SDK for Palo Alto Networks Strata Cloud Manager.

https://cdot65.github.io/pan-scm-sdk/

Apache License 2.0

0 stars 0 forks source link

Optimize payload exclusion logic in security rule creation. #25

Closed cdot65 closed 4 days ago

cdot65 commented 4 days ago

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

[x] Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
[x] Target your pull request to the main development branch in this repository.
[x] Ensure your commit messages follow the project's preferred format.
[x] Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description

Corrected the create method for security rules to support missing keys to be provided with default values from the model

What does this pull request accomplish?

Bug fix

Are there any breaking changes included?

[ ] Yes
[x] No

Is there anything the reviewers should know?

Thank you for your contributions!

codecov-commenter commented 4 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines	Coverage Δ
scm/config/security/security_rule.py	`100.00% <100.00%> (ø)`