cds-astro / mocpy

Python library to easily create and manipulate MOCs (Multi-Order Coverage maps)
https://cds-astro.github.io/mocpy/
BSD 3-Clause "New" or "Revised" License
60 stars 33 forks source link

Possible breaking changes needed for v1.0.0 #97

Open ManonMarchand opened 1 year ago

ManonMarchand commented 1 year ago
ManonMarchand commented 1 year ago

Here is a list (to be completed if I forgot something) of the new features of v0.12.0

  1. +, |, -, &, ~ operators redefinition for union, union, difference, intersect and complement respectively.
    moc1 + moc2

    and

    moc1 - moc2
  2. a rapid display of the mocs is now callable with
    moc.display_preview()
  3. WCS now finds automatically the center and size of the mocs for an automatic plot when the users don't provide these parameters
    # example to write here
  4. add MOC.barycenter and MOC.largest_distance_from_coo_to_vertices of a moc
fxpineau commented 11 months ago

Since MOCPy has been partly developed on European projects (@bmatthieu3 ?) and relies on MOC Lib Rust which has also been partly developed on the ESCAPE European projects, (another one before @bmatthieu3 ?), we probably should add an Acknowledgements section.

For ESCAPE it would be (see MOC Lib Rust):

This work has been partly supported by the ESCAPE project.  
ESCAPE - The **E**uropean **S**cience **C**luster of **A**stronomy & **P**article Physics **E**SFRI Research Infrastructures -
has received funding from the **European Union’s Horizon 2020** research and innovation programme under **Grant Agreement no. 824064**. 
ManonMarchand commented 11 months ago

Citations infos ?

ManonMarchand commented 4 months ago

To be discussed:

tboch commented 4 months ago

My suggestion: stick to the vocabulary of the MOC standard (ie order). MOCLibRust has introduced depth which is used nowhere else to my knowledge.

fxpineau commented 4 months ago

depth is a very common term in generic tree data structures, see e.g here, or this O'Mullane paper. I introduced it when I was working on abstract quad-tree indexation schemes (possibly implemented by HTM, HEALPix, HEAZIP I thought I invented but that was already existing (I do not remember the original name: depht 0 cells are made of 3 depth 1 zones + an upper triangle, at depth 2 each zone is then defided into 4 sub-zones while the upper triangle is divided into 3 sub-zones + an upper triangle, and so on), ...). But I agree that the common term in the HEALPix ecosystem is order probably since the NESTED indexation scheme is based on the Z-order curve.