cds-snc / notification-planning-core

Project planning for GC Notify Core Team

0 stars 0 forks source link

Turn on new Pinpoint code in production: initial release #361

Open sastels opened 5 months ago

sastels commented 5 months ago

Description

As a Notify user, I need my SMS to be sent from the appropriate numbers

WHY are we building?

We have brought the pinpoint code back into the code base and it seems to be working. We will now enable it in production.

WHAT are we building?

Turn on Pinpoint code in production.

VALUE created by our solution

Will be able to restrict shortcode usage.

Acceptance Criteria

[x] initial release of pinpoint only uses pinpoint for a few templates. Rest go through SNS.

QA Steps (in production)

[x] Send an sms using a staging or production template in the shortcode list. It should be sent from the Pinpoint shortcode pool.
[x] Send an sms using a template not in the list. It should be sent by SNS.

sastels commented 5 months ago

This PR will allow us to use pinpoint for a few templates and SNS for the rest https://github.com/cds-snc/notification-api/pull/2184

sastels commented 5 months ago

PR merged. Currently (and tested) in staging:

Send an sms using a template in the SC list. It should be sent by Pinpoint (in the logs you should see AWS Pinpoint request finished in ...)
Send an sms using a template not in the list. It should be sent from SNS (AWS SNS request finished in ...).

After we release this to prod we will set values for prod AWS_PINPOINT_SC_POOL_ID and AWS_PINPOINT_SC_TEMPLATE_IDS. This will bring production to the same state as staging (Pinpoint for certain templates, SNS for the rest).

sastels commented 5 months ago

PR merged. Currently in staging (and tested) :

Send an sms using a template in the SC list. It should be sent by Pinpoint (in the logs you should see AWS Pinpoint request finished in ...)
Send an sms using a template not in the list. It should be sent from SNS (AWS SNS request finished in ...).

After we release this to prod we will turn on the shortcode pool in production: https://github.com/cds-snc/notification-manifests/pull/2652

I have added the production shortcode to the shortcode pool. This required updating the pool keywords to be the same as the shortcode keywords (to add a number to an existing pool the keywords must agree).

ben851 commented 5 months ago

2184 has been merged, and will be released today. After that we can proceed with #2652

sastels commented 5 months ago

The shortcode pinpoint delivery receipts and the longcode delivery receipts are different. Merged and tested in staging: https://github.com/cds-snc/notification-api/pull/2189

Next step: release to prod tomorrow and test there.

ben851 commented 5 months ago

The short code doesn't send back the same responses as long codes, and we had to make a change that will be released today.

sastels commented 5 months ago

short code delivery receipts processed correctly now :tada:

ben851 commented 5 months ago

@ben851 to QA

ben851 commented 5 months ago

Sent two messages, verified that pinpoint was sent by pinpoint, and the other was sent by SNS.