cds-snc / notification-planning

Project planning for GC Notify Team
5 stars 0 forks source link

Custom logos are displayed larger than expected #1679

Open andrewleith opened 1 month ago

andrewleith commented 1 month ago

Describe the bug

Notify gives specific instructions for users to size their logos when they upload them, but when they follow them, the logo ends up larger than expected.

Note: If we fix this, we need to think about how to handle existing logos. We could either go back and fix them all, or perhaps only re-size images properly going forward.

If we can’t change how logos are displayed, we could instead change our instructions.

Instructions:

Your logo must be compatible with GC Notify. Check logo is:

In PNG image format Exactly 108 pixels tall Maximum 600 pixels wide

Result: image

However, it should look like this: image SEV-4 Low

To Reproduce

Steps to reproduce the behavior:

  1. Upload a custom logo and follow the sizing instructions
  2. Logo is larger than expected

Expected behavior

Impact

Impact on Notify users:

Impact on Recipients:

Impact on Notify team:

whabanks commented 3 weeks ago

We had another instance of this bug causing issues with banner resizing: https://gcdigital.slack.com/archives/C03FA4DJCCU/p1730803609010149

yaelberger-commits commented 1 week ago

Temp fix is to use #FFFFFF background and select "Custom logo on a background colour"