Hotfix na logic update - Githubissues

cds-snc / tracker

Check whether a Government of Canada domain is adhering to best security practices.

Other

12 stars 9 forks source link

Hotfix na logic update #62

Closed sayaHub closed 5 years ago

sayaHub commented 5 years ago

Hello,

Just a logic update in handling N/A when checking for ITPIN compliance. When no data for crypto or cert, ITPIN will not be compliant. issue #62

obrien-j commented 5 years ago

This pull request fixes 1 alert when merging 0ac3d63be1b9ce03cdaef28aede3922ba1509e35 into 42429bf30837947c992d90ba5460bf0c813a31fc - view on LGTM.com

fixed alerts:

1 for Module is imported with 'import' and 'import from'

Comment posted by LGTM.com

obrien-j commented 5 years ago

This pull request fixes 1 alert when merging e201d4f6d831bec7433aeb1bf5c395348cf53487 into 42429bf30837947c992d90ba5460bf0c813a31fc - view on LGTM.com

fixed alerts:

1 for Module is imported with 'import' and 'import from'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

obrien-j commented 5 years ago

This pull request fixes 1 alert when merging 1e9ce8821ac07d611e5a55fdc645d6ccc1e23c85 into 42429bf30837947c992d90ba5460bf0c813a31fc - view on LGTM.com

fixed alerts:

1 for Module is imported with 'import' and 'import from'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

obrien-j commented 5 years ago

This pull request fixes 1 alert when merging 97cebd68c5def3a29e987462f9082cac6db57943 into 42429bf30837947c992d90ba5460bf0c813a31fc - view on LGTM.com

fixed alerts:

1 for Module is imported with 'import' and 'import from'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

obrien-j commented 5 years ago

This pull request fixes 1 alert when merging e7be98b02f45b7786a1b88fb416ac58bc975daa4 into 42429bf30837947c992d90ba5460bf0c813a31fc - view on LGTM.com

fixed alerts:

1 for Module is imported with 'import' and 'import from'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

obrien-j commented 5 years ago

This pull request fixes 1 alert when merging 6226a687ce855dadf4828f4357fb190cfeae1c18 into 42429bf30837947c992d90ba5460bf0c813a31fc - view on LGTM.com

fixed alerts:

1 for Module is imported with 'import' and 'import from'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com