Schema based parsing currently supports parsing action attributes according to their types, but the Cedar schema format does not support defining actions with their attributes or declaring the type of their attributes, so this code is not reachable by consumers of the Cedar library.
By deleting this code we can remove a caller of schematype_of_partialvalue which is known to be buggy for set and records.
Note that action entities are compared against the action entities from the schema when constructing an Entities object, so we still report an error if an action entity contains unexpected attributes.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
[ ] A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
[ ] A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
[ ] A bug fix or other functionality change requiring a patch to cedar-policy.
[x] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
[ ] A change (breaking or otherwise) that only impacts unreleased or experimental code.
I confirm that this PR (choose one, and delete the other options):
[ ] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
[x] Does not update the CHANGELOG because my change does not significantly impact released code.
I confirm that cedar-spec (choose one, and delete the other options):
[x] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
[ ] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
[ ] Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
[ ] I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)
Description of changes
Schema based parsing currently supports parsing action attributes according to their types, but the Cedar schema format does not support defining actions with their attributes or declaring the type of their attributes, so this code is not reachable by consumers of the Cedar library.
By deleting this code we can remove a caller of
schematype_of_partialvaluewhich is known to be buggy for set and records.Note that action entities are compared against the action entities from the schema when constructing an
Entitiesobject, so we still report an error if an action entity contains unexpected attributes.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)