celery / django-celery-results

Celery result back end with django
Other
668 stars 206 forks source link

Revert "feat: raw delete expired instead of `Queryset.delete` (#235)" #384

Closed hansegucker closed 1 year ago

hansegucker commented 1 year ago

This partially reverts commit 7c7cb67fb818b7e37dbb8e7ad52ec8ce6f2faada as recommended in https://github.com/celery/django-celery-results/pull/235#issuecomment-1385032707. This also fixes https://github.com/celery/django-celery-results/issues/383.

hansegucker commented 1 year ago

can you please check the CI failures?

The fix for the CI failure is in https://github.com/celery/django-celery-results/pull/382 (at least partially). The full fix can be found in the latest commit of this PR.

hansegucker commented 1 year ago

Please rerun CI with current changes.

auvipy commented 1 year ago

we have only one test to fix =========================== short test summary info ============================ ERROR t/unit/test_migrations.py::MigrationTests::test_models_match_migrations

hansegucker commented 1 year ago

It would be perfect if we can get a new release with this fix.

auvipy commented 1 year ago

ping me next week

hansegucker commented 1 year ago

@auvipy ping

auvipy commented 1 year ago

Ping again tomorrow please!

hansegucker commented 1 year ago

@auvipy ping again

hansegucker commented 1 year ago

@auvipy ping, ping ;-)

auvipy commented 1 year ago

sorry forgot about it with other priorities!

auvipy commented 1 year ago

released!

hansegucker commented 1 year ago

Thank you very much!

auvipy commented 1 year ago

I am sorry for the delay. there are lots of other things to look after so!