search

celestiamobile / AndroidCelestia

Universe simulator reachable on your Android device.
https://celestia.mobi
GNU General Public License v2.0
87 stars 7 forks source link

Fix fastlane path, optimize screenshots #89

Closed licaon-kter closed 6 months ago

licaon-kter commented 6 months ago

Fix https://github.com/celestiamobile/AndroidCelestia/issues/87

ref: https://gitlab.com/-/snippets/1895688#locations

levinli303 commented 6 months ago

I'm reverting this PR since the symlinks are not correctly handled is causing build failures in https://dev.azure.com/CelestiaProject/Celestia/_build/results?buildId=3995&view=results

licaon-kter commented 6 months ago

I didn't add any symlinks, what do you mean?

levinli303 commented 6 months ago

I didn't add any symlinks, what do you mean?

app/src/unofficial/fastlane/metadata/android hosts metadata for Fdroid, not app/src/play/fastlane/metadata/android.

In this PR you moved files from app/src/play/fastlane/metadata/android, you should move files under app/src/unofficial/fastlane/metadata/android instead. since most of the files under app/src/unofficial/fastlane/metadata/android are symlinks, should also fix these.

licaon-kter commented 6 months ago

The OP clearly explains the paths, if we don't use those paths we don't see anything: https://f-droid.org/packages/space.celestia.mobilecelestia/

Fastlane, for better or worse, is a standard of sorts, we can't invent 4500 possible locations for metadata because each developer likes to hide the metadata elsewhere. :(

licaon-kter commented 6 months ago

The other option is Triple-T, again needs certain paths, https://gitlab.com/-/snippets/1901490 and that might fold better on your ideas, like app/src/unofficial/play/...

But I'll need to modify the files and folders and their names to fit Triple-T per the link.

levinli303 commented 6 months ago

you can have the standard path for Fdroid (move app/src/unofficial/fastlane/metadata to root), since we have special logic for handling for Google Play which does not restrict the place where the metadata is put. And Fdroid is the only App Store that we are supporting (unofficially) besides Google Play.

licaon-kter commented 6 months ago

afaik Google Play supports Fastlane and Triple-T (with plugins and such), can you link to this info about their paths used for metadata?

levinli303 commented 6 months ago

afaik Google Play supports Fastlane and Triple-T (with plugins and such), can you link to this info about their paths used for metadata?

for google play, we have a custom script for invoking fastlane for distribution, so it is not an issue which path the meta data is under.

levinli303 commented 6 months ago

how does #91 look ?

licaon-kter commented 6 months ago

F-Droid parses those mentioned paths, it does not read that file.

levinli303 commented 6 months ago

It’s not a text file it’s a symlink. Does it not follow symlinks?

licaon-kter commented 6 months ago

My bad, I misread the mobile client text rendering.

Yes it follows them, and that looks like the second path in the snippet, so it should be fine. 👍

Of note, F-Droid will pickup this path and metadata with the next released version of your app.