search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 285 forks source link

Remove hardcoded Docker image from v3 e2e upgrade test #3947

Open rootulp opened 2 weeks ago

rootulp commented 2 weeks ago

Context

The v3 e2e test needs a slightly modified txsim. Since those modifications were introduced in the same PR as the test, we had to use "pr-3910" as the version for txsim in the test.

Proposal

Remove the "pr-3910" version from the v3 e2e upgrade test

_Originally posted by @evan-forbes in https://github.com/celestiaorg/celestia-app/pull/3910#discussion_r1790664364_

rootulp commented 1 week ago

Note there's an extra complication in addressing this issue. The v3 e2e test needs to override the upgrade height delay. We do that via built tags. The docker image used in the test needs to have the upgrade height overridden to 1. So we need to figure out a mechanism to create new Docker images for celestia-app that overrides the upgrade height to 1.