search

celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
489 stars 269 forks source link

Add simple ABCI app for proper testing #322

Closed liamsi closed 3 years ago

liamsi commented 3 years ago

We should add a modified version of the KVStore which:

For a draft see: https://github.com/lazyledger/lazyledger-core/blob/fc1b60a27c333c606d161cef416b5988d10260ec/abci/example/kvstore/kvstore.go#L178-L185

But we should move this into a separate abci example app instead.

liamsi commented 3 years ago

IMO, this app should not necessarily be run through the --proxy-app flag (or at least not exclusively). It would be good if this ends up in a separate cmd where the user can decide about blocksize (via number of Txs / Msgs and sizes of these) on the command-line. I'll submit a separate PR for this shortly.

BTW, this is basically the same as the dummy app in @musalbas prototype: https://github.com/lazyledger/lazyledger-prototype/blob/master/app_dummy.go

It would actually be neat to have one or two more of these apps ported over to lazyledger-core too. The existing examples could be removed from this repository instead.