celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
491 stars 270 forks source link

Add the ability to prune specific Celestia blocks in the IPFS store #442

Closed evan-forbes closed 3 years ago

evan-forbes commented 3 years ago

Summary

Add the ability to delete a specific block's data in the embedded IPFS node's blockstore, and do so while pruning.

Details

delete block data from the IPFS blockstore for a specific block height while pruning. https://github.com/lazyledger/lazyledger-core/blob/004a1a9abcf95e5f0d5299f18f694146bc9473b4/store/store.go#L312-L316

Action Items

References

Will eventually be related to #393

Wondertan commented 3 years ago

@evan-forbes, @liamsi, what's the use case for pruning?

evan-forbes commented 3 years ago

what's the use case for pruning?

anything that's not a storage node. I think this should have been included in #374, just to not break already existing functionality.

liamsi commented 3 years ago

If we still with the augment tendermint nodes to serve IPFS directly, then an additional feature I'd throw in the mix would be the ability to prune the erasure coding too. This will be a bit tricky as we still want storage nodes to recompute and serve these shares although they were deleted from the local store. So we'd need:

evan-forbes commented 3 years ago

closing as IPFS or erasured block data is no longer included in celestia-core