search

celestiaorg / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Other
19 stars 33 forks source link

feat: merge the QGB v0.46.x branch to the default one #276

Closed rach-id closed 2 years ago

rach-id commented 2 years ago

Merge the QGB feature branch to the default branch in preparation for the QGB app merge.

rach-id commented 2 years ago

@evan-forbes The linter is out of hand. It is failing because of a missing package:

Failure: buf.build/googleapis/googleapis:40f07f5b563941f2b20b991a7aedd53d: does not exist
make: *** [Makefile:431: proto-lint] Error 1

Probably because we're using bufbuild/buf:1.0.0-rc8 for generating proto and linting. We can think of updating the version of buf to match upstream:

DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bufbuild/buf:1.7.0

But that can be handled in a separate PR. Let me know if you agree to create an issue.

PS: I did update it locally, but all the proto generated files were changed. So, it's out of scope of this PR.

For the other failing CI, it's the traditional breaking changes.

Let me know if this is alright, so we merge.

evan-forbes commented 2 years ago

Yeah, let's create an issue and update the proto generation.

Then we can merge that here, and merge this

rach-id commented 2 years ago

@evan-forbes we clicked on the same time :smiley:

evan-forbes commented 2 years ago

:muscle: