search

celestiaorg / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Other
19 stars 33 forks source link

chore: Update the default genesis params #285

Closed evan-forbes closed 1 year ago

evan-forbes commented 2 years ago

Description

During the onsite, we came to a few decisions around selecting a few genesis params. Given how easy they are to change, this PR changes the defaults to the values that we agreed upon. While this increases our diff slightly from upstream, it also will also help us keep params consistent across networks without having to configure them each time.

NOTE: we should not merge this PR, although we are keeping it open to continue the discussion around defualt params

closes https://github.com/celestiaorg/celestia-app/issues/169

evan-forbes commented 2 years ago

Couldn't we wrap the default modules, change the defaults in the respective wrappers, and use these wrapped modules instead of the default ones?

yeah we definitely can do that. initially I didn't do that as it will add even more boiler plate, but I think we'll have to to avoid breaking a bunch of tests

evan-forbes commented 2 years ago

keeping this open for now, as I would like to continue the review process and discussions. but we shouldn't merge