search

celestiaorg / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Other
19 stars 33 forks source link

chore: bump tm fork to v1.12.1 #290

Closed cmwaters closed 1 year ago

evan-forbes commented 1 year ago

looking into why that test is failing, and then will approve

cmwaters commented 1 year ago

It does look as if the previous commit: https://github.com/celestiaorg/cosmos-sdk/commit/7bd9ac2cbdea2e272325a7d71e5c8cb72cf82527 passed this test. I can do a bit of digging.

cmwaters commented 1 year ago

This seems to be coming from the rpc.TxSearch(...) method in Tendermint. I wonder if it has anything to do with changing the the way hashes are calculated in the kv indexer if they're blobs?

cmwaters commented 1 year ago

Ok so I did a somewhat git bisect on the tendermint dependency. It seems the failure happens when we go from v1.4.0-tm-v0.34.20 to v1.5.0-tm-v0.34.20. The most suspicious of these commits are: https://github.com/celestiaorg/celestia-core/commit/534660637ca7f690c994625fd71b57cfe928de19 and https://github.com/celestiaorg/celestia-core/commit/df3814058ebd4343a767111d5975ac7d45807dbd where it looks like we modified how TxSearch and Tx work in regards to the proof. cc @evan-forbes @rootulp

cmwaters commented 1 year ago

Ok I found the problem. It appears to me like everything deadlocks when either Tx or TxSearch is called with prove set to true. Setting it to false in the SDK makes all the tests pass.