Closed cmwaters closed 1 year ago
Merging #304 (0746ab3) into release/v0.46.x-celestia (0aef7ba) will decrease coverage by
0.19%
. The diff coverage is67.81%
.
@@ Coverage Diff @@
## release/v0.46.x-celestia #304 +/- ##
============================================================
- Coverage 65.74% 65.55% -0.19%
============================================================
Files 679 666 -13
Lines 72130 70980 -1150
============================================================
- Hits 47420 46531 -889
+ Misses 22049 21871 -178
+ Partials 2661 2578 -83
Impacted Files | Coverage Δ | |
---|---|---|
baseapp/abci.go | 60.53% <0.00%> (-0.44%) |
:arrow_down: |
baseapp/baseapp.go | 78.61% <0.00%> (ø) |
|
baseapp/options.go | 59.64% <0.00%> (-1.07%) |
:arrow_down: |
crypto/armor.go | 82.96% <ø> (ø) |
|
crypto/keyring/keyring.go | 63.04% <ø> (ø) |
|
server/config/toml.go | 66.66% <ø> (ø) |
|
server/mock/store.go | 17.92% <0.00%> (-0.35%) |
:arrow_down: |
store/cachekv/internal/mergeiterator.go | 0.00% <0.00%> (ø) |
|
store/iavl/store.go | 55.55% <0.00%> (-0.48%) |
:arrow_down: |
store/iavl/tree.go | 65.71% <0.00%> (-3.99%) |
:arrow_down: |
... and 16 more |
where there any changes related to comet BFT that were changed here? should we update core to v0.34.27 before we merge this?
I'm working on celestia-core as well (It's just taking longer than expected). To answer your question, I don't think there are any substantive changes just renaming
Closes https://github.com/celestiaorg/cosmos-sdk/issues/305