Closed distractedm1nd closed 10 months ago
Merging #233 (38c7b23) into master (0e219c8) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 68.30% 68.30%
=======================================
Files 6 6
Lines 1325 1325
=======================================
Hits 905 905
Misses 403 403
Partials 17 17
Files Changed | Coverage Δ | |
---|---|---|
proof.go | 90.17% <100.00%> (ø) |
I still disagree with making fields public only for the point of serialization. These are not fields that should be touched outside of the given methods
Actually true, encapsulation for Proofs is more important for security.
These are not fields that should be touched outside of the given methods
Using autogenerated proto for json completely solves consistency between json and proto, as it also autogenerates json tags(TIL), so it's not that bad after all.
Yeah but the main problem is not being able to define methods on it
I meant keeping native go struct
What is the status on this?
@rootulp Can we get this merged?
Sorry we need one more @celestiaorg/celestia-core approval.
jsonProof is not necessary when we already have pb.Proof, which caused issues because of mismatching field names.
Related: https://github.com/celestiaorg/celestia-node/issues/2631 Specifically: https://github.com/celestiaorg/celestia-node/issues/2631#issuecomment-1708048715