celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.17k stars 92 forks source link

new subtitles trend... not supported. #763

Open D33M0N opened 2 years ago

D33M0N commented 2 years ago

Overview Description: lately there has been this trend that the subtitles are placed in the Subs/filename/ folder. Like:

serial.S01E01.1080p.mkv serial.S01E02.1080p.mkv serial.S01E03.1080p.mkv Subs/serial.S01E01.1080p/1_English.srt Subs/serial.S01E01.1080p/4_Greek.srt Subs/serial.S01E01.1080p/19_whatever.srt Subs/serial.S01E02.1080p/1_English.srt Subs/serial.S01E02.1080p/4_Greek.srt Subs/serial.S01E02.1080p/19_whatever.srt Subs/serial.S01E03.1080p/1_English.srt Subs/serial.S01E03.1080p/4_Greek.srt Subs/serial.S01E03.1080p/19_whatever.srt

Actual Results: And it seems Celluloid fails to find those files itself automatically (spamming J key doesn't find anything). I have always manually load the subtitles file and search for it or copy it into the main mkv file folder.

Expected Results: Celluloid actually finds the related subtitles itself.

Version: 0.21 (the last good version. 0.22 has been unusable.)

gnome-mpv commented 2 years ago

There's a script in mpv's issue tracker that you can use: https://github.com/mpv-player/mpv/issues/9767#issuecomment-1024831645

D33M0N commented 2 years ago

There's a script in mpv's issue tracker that you can use: mpv-player/mpv#9767 (comment)

Thanks, got it to work now. Because it was rather confusing, then for helping others who might stumble upon it:

  1. need to set in celluloid.conf (mpv.conf) sub-auto=all
  2. create file ~/.config/celluloid/scripts/subs.lua with content:
    mp.add_hook('on_load', 10, function ()
    sub_paths = {'Subs'}
    sub_paths[#sub_paths+1]='Subs/' .. mp.get_property('filename/no-ext')
    mp.set_property_native('sub-file-paths', sub_paths)
    end)

    (this will also nullify any config other than sub-file-paths = Subs for sub-file-paths (like if you had there several different options, like sub:subs:Subs:subtitles:whatever, so you better add them somehow to the .lua file you just created)

mixslad commented 2 years ago

Overview Description: lately there has been this trend that the subtitles are placed in the Subs/filename/ folder. Like:

serial.S01E01.1080p.mkv serial.S01E02.1080p.mkv serial.S01E03.1080p.mkv Subs/serial.S01E01.1080p/1_English.srt Subs/serial.S01E01.1080p/4_Greek.srt Subs/serial.S01E01.1080p/19_whatever.srt Subs/serial.S01E02.1080p/1_English.srt Subs/serial.S01E02.1080p/4_Greek.srt Subs/serial.S01E02.1080p/19_whatever.srt Subs/serial.S01E03.1080p/1_English.srt Subs/serial.S01E03.1080p/4_Greek.srt Subs/serial.S01E03.1080p/19_whatever.srt

Actual Results: And it seems Celluloid fails to find those files itself automatically (spamming J key doesn't find anything). I have always manually load the subtitles file and search for it or copy it into the main mkv file folder.

Expected Results: Celluloid actually finds the related subtitles itself.

Version: 0.21 (the last good version. 0.22 has been unusable.)

so whats your final mpv.conf, i only have the sub-auto=all and sub-file-paths=subs

D33M0N commented 2 years ago

so whats your final mpv.conf, i only have the sub-auto=all and sub-file-paths=subs

doesn't really matter, as long as you have "sub-auto=all" there.

but I have:

save-position-on-quit
slang=en
alang=en
sub-file-paths=Subs
sub-auto=all

reset-on-next-file=all
volume=20
mpv-volume=20

as an additional comment, I can't still put my finger on the problem, but it doesn't always load the extra subtitles in the subfolders. it's like you have to like open the video file several times or scroll it back to beginning (home button) or fiddle around and then suddenly the subs are there.