GLSL-Shaders not working

gsantner commented 2 years ago

Overview Description:

The issue is that glsl-shaders do not work in celluloid/gnome-mpv, but do in normal mpv.

In mpv shaders can be used to improve video quality a lot. This however does not work in celluloid. It only doesn't work, I don't see any error message in logs.
Example setup: https://github.com/bloc97/Anime4K/blob/master/md/GLSL_Instructions_Linux.md
I have a symlink of mpv to celluloid, same scripts/mpv.conf/input.conf/shaders. (input&mpv.conf also set int celluloid settings). So other settings apply correctly, input shortcut also work.
Example conf loading from link above - CTRL+4 no-osd change-list glsl-shaders set "~~/shaders/ .... show-text "Mode A+A (HQ) - I press CTRL+4 and see direct quality improvement in mpv, and a OSD message that this Mode A+A loaded.
In celluloid I also get that Mode A+A message, but video quality stays unchaned.

Steps to Reproduce:

Use glsl-shaders= in mpv-options, in mpv.conf or via lua scripts
it doesn't work, no quality improvement

Version:

Latest Debian version (bullseye 11)

grafik

gnome-mpv commented 2 years ago

CTRL+4 no-osd change-list glsl-shaders set "~~/shaders/ .... show-text "Mode A+A (HQ)

~~ doesn't work in Celluloid right now due to #687. It should work if you use absolute paths instead.

gsantner commented 2 years ago

Can WorkingDirectory in .desktop maybe set to something so it resolves correctly? (i.e. workaround)

gnome-mpv commented 2 years ago

Maybe. I guess it could work if you set WorkingDirectory to Celluloid's config dir.

RobotRoss commented 1 year ago

1 to this issue. I have an absolute path to my shader defined in my mpv.conf file, and it's set to load in Celluloid, but the shader is never actually loaded when playing video.

gnome-mpv commented 1 year ago

@RobotRoss Do you see any errors in the log?

chermnyx commented 6 months ago

I can't reproduce it with absolute path to the shaders and vo=gpu-next, the shaders get loaded and look as expected

RobotRoss commented 5 months ago

I decided to revisit this as I've just installed a new system.

Seems like part of the issue is that the flatpak permissions are not set to allow access to the home directory. Using flatseal to manually grant access to the home directory allowed the shader to load.

This was using an absolute path - I haven't tried a relative path.

As an aside, if a shader fails to load (e.g. for the above permissions issue) it'd be very helpful if an error message popped up informing the user of the issue instead of silently failing.

celluloid-player / celluloid