search

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
594 stars 87 forks source link

Revert removal of addr and peeraddr delegates #168

Closed tinco closed 9 years ago

tinco commented 9 years ago

Fixes the issue reported in #166

digitalextremist commented 9 years ago

@d-snp have you verified this works as expected? I seem to remember that on some versions of the socket the peeraddr method does not return the information anticipated. If you can confirm this does work, I'll merge it in.

tinco commented 9 years ago

I added some silly specs to confirm the existance of the delegators and that they respond the peer addr tuples. It seems to be working but I haven't tested it outside of the specs. If the socket wasn't a true TCPSocket then I think the peeraddr/addr methods would be missing, that's what you were getting at right? Or is there something I should test out in a real world scenario?

kenichi commented 9 years ago

great work on the wsdriver integration - i've updated angelo to work with this PR :+1:

when this merges, i'll merge https://github.com/kenichi/angelo/pull/50 and update Gemfile

digitalextremist commented 9 years ago

Looks good @d-snp! Merging @kenichi, so you ought to be good to go.