celo-org / op-geth

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Return 0 L1 fees (not nil) #245

Closed karlb closed 1 month ago

karlb commented 1 month ago

Returning nil works inside geth, but optimism tests expect the l1CostFunc to return non-nil values. Considering our l1CostFunc is the only one retuning nil values, it seems more pragmatic to change that rather than adapting external code to deal correctly with nil values.