celzero / firestack

Userspace wireguard and network monitor
https://rethinkdns.com/app
Mozilla Public License 2.0
88 stars 15 forks source link

nilaway bust on go1.23 #82

Closed ignoramous closed 1 month ago

ignoramous commented 1 month ago
panic: Cannot range over: func(yield func(E) bool)

goroutine 8247 [running]:
golang.org/x/tools/go/ssa.(*builder).rangeStmt(0xc02cb17290, 0xc02cb30340, 0xc002fbede0, 0x0)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2281 +0x814
golang.org/x/tools/go/ssa.(*builder).stmt(0xc02cb17290, 0xc02cb30340, {0x940b40?, 0xc002fbede0?})
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2505 +0x205
golang.org/x/tools/go/ssa.(*builder).stmtList(...)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:910
golang.org/x/tools/go/ssa.(*builder).stmt(0xc02cb17290, 0xc02cb30340, {0x9409c0?, 0xc0037b84e0?})
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2467 +0xe47
golang.org/x/tools/go/ssa.(*builder).buildFromSyntax(0xc02cb17290, 0xc02cb30340)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2579 +0x245
golang.org/x/tools/go/ssa.(*builder).buildFunction(0x84a020?, 0xc02cb30340)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2533 +0x17b
golang.org/x/tools/go/ssa.(*builder).iterate(0xc02cb17290)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2521 +0x25
golang.org/x/tools/go/ssa.(*Package).build(0xc02cb13180)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2650 +0xa9
sync.(*Once).doSlow(0xc00c0612b0?, 0xc0035f2420?)
    /opt/hostedtoolcache/go/1.23.0/x64/src/sync/once.go:76 +0xb4
sync.(*Once).Do(...)
    /opt/hostedtoolcache/go/1.23.0/x64/src/sync/once.go:67
golang.org/x/tools/go/ssa.(*Package).Build(...)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/ssa/builder.go:2639
golang.org/x/tools/go/analysis/passes/buildssa.run(0xc00c061110)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/analysis/passes/buildssa/buildssa.go:59 +0x2df
golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce(0xc00d6e6aa0)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/analysis/internal/checker/checker.go:775 +0x9bf
sync.(*Once).doSlow(0xc01156c8a0?, 0x948510?)
    /opt/hostedtoolcache/go/1.23.0/x64/src/sync/once.go:76 +0xb4
sync.(*Once).Do(...)
    /opt/hostedtoolcache/go/1.23.0/x64/src/sync/once.go:67
golang.org/x/tools/go/analysis/internal/checker.(*action).exec(...)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/analysis/internal/checker/checker.go:691
golang.org/x/tools/go/analysis/internal/checker.execAll.func1(0xc014c81470?)
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/analysis/internal/checker/checker.go:679 +0x3b
created by golang.org/x/tools/go/analysis/internal/checker.execAll in goroutine 8245
    /home/runner/go/pkg/mod/golang.org/x/tools@v0.18.0/go/analysis/internal/checker/checker.go:685 +0x15a

Disabled for time-being: https://github.com/celzero/firestack/commit/6820740e99c2e1eb5db6cae3b0255e465f6afed1

Ref: https://github.com/uber-go/nilaway/issues/269