quickstart/tracing/python: use new import paths

ralewis85 commented 5 years ago

Zipkin Exporter is now part of the opencensus-ext-zipkin package, https://opencensus.io/exporters/supported-exporters/python/zipkin/

A PR has also been filed against opencensus-quickstarts repo to fix this change as well. https://github.com/opencensus-otherwork/opencensus-quickstarts/pull/1

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

odeke-em commented 5 years ago

Please sign the CLA @ralewis85 and comment here once you are done.

ralewis85 commented 5 years ago

Thanks @odeke-em. I hope to have this signed by early next week. Waiting for company approval on my end.

ralewis85 commented 5 years ago

@odeke-em my employer has noted the CLA has been approved and signed. Please let me know if there are any issues!

songy23 commented 5 years ago

ping @googlebot

songy23 commented 5 years ago

Hi @ralewis85 I think the problem is you need to use your corporate email for this commit. Otherwise CLA checker won't be able to find it.

odeke-em commented 5 years ago

@songy23 I think he did use his corporate email as per https://patch-diff.githubusercontent.com/raw/census-instrumentation/opencensus-website/pull/674.patch

songy23 commented 5 years ago

That's a bit weird, can you try rebase and push again?

ralewis85 commented 5 years ago

Still no luck after a rebase and push. I have both a personal email and corporate email attached to this github account (as you can see from the patch above I'm committing this under my corporate address). Does that introduce any oddness to Googlebot's checker? Do I need to do anything special in my profile settings like disable email privacy?

odeke-em commented 5 years ago

Interesting! @ralewis85 perhaps you can open another PR afresh and if that one works we can then close this one. I noticed today that Github asked me to select an email address to use before merging a PR -- which is quite odd and new.

ralewis85 commented 5 years ago

@odeke-em #683 opening a fresh PR did not seem to fix the issue. Is there a way to confirm that the email address in this / the other PR is in the approved CLA list? Perhaps something went awry on our end and I am somehow not present?

ralewis85 commented 5 years ago

@songy23 I closed out that duplicate PR. Seems making the second one did not help. I've confirmed on our end that the google group added to the CLA does include my corporate email address, the same that appears in the diff above. I'm a bit perplexed on next steps.

songy23 commented 5 years ago

There might be a problem with @googlebot. Given the fact that New Relic is already on the list and you've confirmed your email is included, I'll manually verify CLA this time.

googlebot commented 5 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

songy23 commented 5 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

See the discussions above.

census-instrumentation / opencensus-website