center-for-learning-management / moodle-block_gps

Moodle Block Plugin to determine the current user-position
GNU General Public License v3.0
2 stars 0 forks source link

MOODLE_404_STABLE compatibility (migrate before_standard_html_head to new hook callback) #12

Open ralf-krause opened 3 months ago

ralf-krause commented 3 months ago

Dear developers, the geolocation tools are very important tools for me and my teacher workshops.

Since I updated my test page to Moodle 4.5dev (20240719) I could not register the site at Moodle annymore. See https://tracker.moodle.org/browse/MDL-82556. Therefore I switched on the debugging to developer mode and I get the following debug messages for the plugin block_gps. Yes, I controlled this also in my productive sites running Moodle 4.4.1+ (20240719).

I hope you will get a fix for this problem very soon. Best regards, Ralf

Callback before_standard_html_head in block_gps component should be migrated to new hook callback for core\hook\output\before_standard_head_html_generation
line 7243 of /lib/moodlelib.php: call to debugging()
line 7310 of /lib/moodlelib.php: call to {closure}()
line 73 of /lib/classes/hook/output/before_standard_head_html_generation.php: call to get_plugins_with_function()
line 197 of /lib/classes/output/core_renderer.php: call to core\hook\output\before_standard_head_html_generation->process_legacy_callbacks()
line 219 of /lib/mustache/src/Mustache/Context.php: call to core\output\core_renderer->standard_head_html()
line 138 of /lib/mustache/src/Mustache/Context.php: call to Mustache_Context->findVariableInStack()
line 31 of /var/moodledata2/localcache/mustache/1721808754/boost/__Mustache_73560842f9d6c5bc337558df4f13b989.php: call to Mustache_Context->findDot()
line 13 of /var/moodledata2/localcache/mustache/1721808754/boost/__Mustache_4aa1b29b14b62e9eb02cc88038b79589.php: call to __Mustache_73560842f9d6c5bc337558df4f13b989->renderInternal()
line 66 of /lib/mustache/src/Mustache/Template.php: call to __Mustache_4aa1b29b14b62e9eb02cc88038b79589->renderInternal()
line 192 of /lib/classes/output/renderer_base.php: call to Mustache_Template->render()
line 107 of /theme/boost/layout/drawers.php: call to core\output\renderer_base->render_from_template()
line 966 of /lib/classes/output/core_renderer.php: call to include()
line 889 of /lib/classes/output/core_renderer.php: call to core\output\core_renderer->render_page_layout()
line 58 of /admin/search.php: call to core\output\core_renderer->header()
lassnj commented 2 months ago

Relates to https://github.com/center-for-learning-management/eduvidual-src/issues/2043

ralf-krause commented 2 months ago

The link does not work.

lassnj commented 2 months ago

The link does not work.

It's just an internal reference to our private repository.

ralf-krause commented 2 weeks ago

Please tell me if the gps plugins will be repaired for Moodle 4.5.

lassnj commented 2 weeks ago

Please tell me if the gps plugins will be repaired for Moodle 4.5.

We scheduled the fix but it won't be ready before January 2025.