center-for-threat-informed-defense / caldera_pathfinder

Pathfinder is a plugin for mapping network vulnerabilities, scanned by CALDERA or imported by a supported network scanner, and translating those scans into adversaries for network traversal.
https://caldera.mitre.org/
Apache License 2.0
121 stars 26 forks source link

UI bug fixes and improvements from CALDERA v4 #42

Closed CDJellen closed 2 years ago

CDJellen commented 2 years ago

Description

CALDERA version 4 includes a number of UI improvements which induce non-breaking bugs to the Pathfinder UI. The easiest to notice is the inability to switch tabs as expected if Pathfinder is loaded before other CALDERA plugins. By migrating the template to Apline, including x-data and x-init features, these bugs can be resolved. Alpine can also be used for intuitive, fine-grain control of what information is presented to users, and under which circumstances with x-show. The report modification and adversary creation features are now nested, displaying more information on how each can be used.

The core API and HTML are relatively unchanged, but bugs with scanning, CALDERA tab navigation, and UI conflicts have been resolved. Small changes were made to pathfinder.css and graph.css for a cleaner layout, more in-line with the visual style of CALDERA v4.

Type of change

How Has This Been Tested?

This branch was tested locally in five key ways:

  1. scanning features, including nmap and nmap-vulners were verified to work correctly in the context of the CALDERA v4 changes.
  2. Report importing was tested using both the nmap and caldera parsers.
  3. Reports were re-named, deleted, and downloaded to verify correct API functionality.
  4. Graph objects for sparse and well-populated scans were tested to ensure the graph element was sufficiently large.
  5. Past features, including conditionally-available buttons, were verified by repeating the above to emulate user behavior.

Checklist:

elegantmoose commented 2 years ago

@CDJellen - add one of our UI developers to review this too.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication